Skip to content

Commit dedb799

Browse files
authored
refactor(cdk-experimental/menu): rename cdk selectable output and add cdk specific output naming (#20267)
1 parent 9d309f7 commit dedb799

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

src/cdk-experimental/menu/menu-group.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export class CdkMenuGroup implements AfterContentInit, OnDestroy {
6363

6464
/** Register each selectable to emit on the change Emitter when clicked */
6565
private _registerClickListener(selectable: CdkMenuItemSelectable) {
66-
selectable.clicked
66+
selectable.toggled
6767
.pipe(takeUntil(this._selectableChanges))
6868
.subscribe(() => this.change.next(selectable));
6969
}

src/cdk-experimental/menu/menu-item-checkbox.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ describe('MenuItemCheckbox', () => {
7878

7979
it('should emit on clicked emitter when triggered', () => {
8080
const spy = jasmine.createSpy('cdkMenuItemCheckbox clicked spy');
81-
checkbox.clicked.subscribe(spy);
81+
checkbox.toggled.subscribe(spy);
8282

8383
checkbox.trigger();
8484

@@ -87,7 +87,7 @@ describe('MenuItemCheckbox', () => {
8787

8888
it('should not emit on clicked emitter when disabled', () => {
8989
const spy = jasmine.createSpy('cdkMenuItemCheckbox clicked spy');
90-
checkbox.clicked.subscribe(spy);
90+
checkbox.toggled.subscribe(spy);
9191
checkbox.disabled = true;
9292

9393
checkbox.trigger();

src/cdk-experimental/menu/menu-item-radio.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ describe('MenuItemRadio', () => {
7474

7575
it('should emit on clicked emitter when triggered', () => {
7676
const spy = jasmine.createSpy('cdkMenuItemRadio clicked spy');
77-
radioButton.clicked.subscribe(spy);
77+
radioButton.toggled.subscribe(spy);
7878

7979
radioButton.trigger();
8080

@@ -83,7 +83,7 @@ describe('MenuItemRadio', () => {
8383

8484
it('should not emit on clicked emitter when disabled', () => {
8585
const spy = jasmine.createSpy('cdkMenuItemRadio clicked spy');
86-
radioButton.clicked.subscribe(spy);
86+
radioButton.toggled.subscribe(spy);
8787
radioButton.disabled = true;
8888

8989
radioButton.trigger();

src/cdk-experimental/menu/menu-item-selectable.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ let nextId = 0;
2020
@Directive()
2121
export abstract class CdkMenuItemSelectable extends CdkMenuItem {
2222
/** Event emitted when the selectable item is clicked */
23-
@Output() clicked: EventEmitter<CdkMenuItemSelectable> = new EventEmitter();
23+
@Output('cdkMenuItemToggled') toggled: EventEmitter<CdkMenuItemSelectable> = new EventEmitter();
2424

2525
/** Whether the element is checked */
2626
@Input()
@@ -41,7 +41,7 @@ export abstract class CdkMenuItemSelectable extends CdkMenuItem {
4141
/** If the element is not disabled emit the click event */
4242
trigger() {
4343
if (!this.disabled) {
44-
this.clicked.next(this);
44+
this.toggled.next(this);
4545
}
4646
}
4747

0 commit comments

Comments
 (0)