Skip to content

Commit e6e2382

Browse files
authored
build: remove test blocklist (#18372)
The blocklist will be no longer used in the framework repository, so we can remove it from the components repo too. Related to FW-1807.
1 parent 0d108d3 commit e6e2382

File tree

3 files changed

+1
-35
lines changed

3 files changed

+1
-35
lines changed

test/BUILD.bazel

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ ts_library(
1010
name = "angular_test_init",
1111
testonly = True,
1212
# This file *must* end with "spec" in order for "karma_web_test_suite" to load it.
13-
srcs = [
14-
"angular-test-init-spec.ts",
15-
"test-blocklist.ts",
16-
],
13+
srcs = ["angular-test-init-spec.ts"],
1714
deps = [
1815
"@npm//@angular/core",
1916
"@npm//@angular/platform-browser-dynamic",

test/angular-test-init-spec.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import {
33
BrowserDynamicTestingModule,
44
platformBrowserDynamicTesting,
55
} from '@angular/platform-browser-dynamic/testing';
6-
import {testBlocklist} from './test-blocklist';
76

87
/*
98
* Common setup / initialization for all unit tests in Angular Material and CDK.
@@ -55,16 +54,3 @@ function patchTestBedToDestroyFixturesAfterEveryTest(testBedInstance: TestBed) {
5554
// https://github.com/angular/angular/blob/master/packages/core/testing/src/before_each.ts#L25
5655
afterEach(() => testBedInstance.resetTestingModule());
5756
}
58-
59-
60-
// Filter out any tests explicitly given in the blocklist. The blocklist is empty in the
61-
// components repository, but the file will be overwritten if the framework repository runs
62-
// the Angular component test suites against the latest snapshots. This is helpful because
63-
// sometimes breaking changes that break individual tests land in the framework repository.
64-
// It should be possible to disable these tests until the component repository migrated the
65-
// broken tests once the breaking change is released.
66-
(jasmine.getEnv() as any).configure({
67-
specFilter: function(spec: jasmine.Spec) {
68-
return !testBlocklist || !testBlocklist[spec.getFullName()];
69-
}
70-
});

test/test-blocklist.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)