Skip to content

Commit eeda0ff

Browse files
committed
build: switch to chromium provided in dev-infra package
Switches the chromium version provided in the shared dev-infra package. This gives us better control over used versions, and we get RBE optimizations that have been applied to these browsers. Closes #19543.
1 parent c05a07e commit eeda0ff

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

WORKSPACE

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,10 @@ web_test_repositories()
8888
load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories")
8989

9090
browser_repositories(
91-
chromium = True,
91+
# Chrome is brought in by `@npm_dev_infra_private` for better version control and
92+
# RBE experience where individual browser archives per platform are provided.
93+
# TODO: Do the same for Firefox (but it is not used for local development): DEV-114
94+
chromium = False,
9295
firefox = True,
9396
)
9497

scripts/run-component-tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ if (local && (components.length > 1 || all)) {
6161
process.exit(1);
6262
}
6363

64-
const browserName = firefox ? 'firefox-local' : 'chromium-local';
64+
const browserName = firefox ? 'firefox-local' : 'chromium';
6565
const bazelBinary = `yarn -s ${watch ? 'ibazel' : 'bazel'}`;
6666
const configFlag = viewEngine ? '--config=view-engine' : '';
6767

tools/defaults.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,7 @@ def karma_web_test_suite(name, **kwargs):
194194
def protractor_web_test_suite(flaky = True, **kwargs):
195195
_protractor_web_test_suite(
196196
flaky = flaky,
197+
browsers = ["@npm_angular_dev_infra_private//browsers:chromium"],
197198
**kwargs
198199
)
199200

@@ -244,7 +245,7 @@ def ng_web_test_suite(deps = [], static_css = [], bootstrap = [], tags = [], **k
244245
browsers = [
245246
# Note: when changing the browser names here, also update the "yarn test"
246247
# script to reflect the new browser names.
247-
"@io_bazel_rules_webtesting//browsers:chromium-local",
248+
"@npm_angular_dev_infra_private//browsers:chromium",
248249
"@io_bazel_rules_webtesting//browsers:firefox-local",
249250
],
250251
bootstrap = [

0 commit comments

Comments
 (0)