cleaned up ci

Author: hansl

.travis.yml

@@ -29,7 +29,6 @@ env:
   matrix:
     # Order: a slower build first, so that we don't occupy an idle travis worker waiting for others to complete.
     - MODE=lint
-    - MODE=circular_deps
     - MODE=extract_metadata
     - MODE=e2e
     - MODE=saucelabs_required

scripts/ci/build-and-test.sh

@@ -15,8 +15,6 @@ start_tunnel
 wait_for_tunnel
 if is_lint; then
   $(npm bin)/gulp ci:lint
-elif is_circular_deps_check; then
-  $(npm bin)/gulp ci:check-circular-deps
 elif is_e2e; then
   $(npm bin)/gulp ci:e2e
 elif is_extract_metadata; then

scripts/ci/sources/mode.sh

@@ -9,10 +9,6 @@ is_lint() {
   [[ "$MODE" = lint ]]
 }
 
-is_circular_deps_check() {
-  [[ "$MODE" = circular_deps ]]
-}
-
 is_extract_metadata() {
   [[ "$MODE" = extract_metadata ]]
 }

tools/gulp/tasks/ci.ts

@@ -1,15 +1,10 @@
-import gulp = require('gulp');
-import {execNodeTask} from '../task_helpers';
+import {task} from 'gulp';
 
 
-gulp.task('ci:lint', ['ci:forbidden-identifiers', 'lint']);
-gulp.task('ci:test', ['test:single-run'], function() {
-  process.exit(0);
-});
-gulp.task('ci:e2e', ['e2e']);
-gulp.task('ci:extract-metadata', [':build:components:ngc']);
-gulp.task('ci:forbidden-identifiers', function() {
+task('ci:lint', ['ci:forbidden-identifiers', 'lint']);
+task('ci:test', ['test:single-run'], function() { process.exit(0); });
+task('ci:e2e', ['e2e']);
+task('ci:extract-metadata', [':build:components:ngc']);
+task('ci:forbidden-identifiers', function() {
   require('../../../scripts/ci/forbidden-identifiers.js');
 });
-
-gulp.task('ci:check-circular-deps', ['madge']);

tools/gulp/tasks/lint.ts

@@ -2,7 +2,7 @@ import gulp = require('gulp');
 import {execNodeTask} from '../task_helpers';
 
 
-gulp.task('lint', ['tslint', 'stylelint']);
+gulp.task('lint', ['tslint', 'stylelint', 'madge']);
 gulp.task('madge', ['build:release'], execNodeTask('madge', ['--circular', './dist']));
 gulp.task('stylelint', execNodeTask(
   'stylelint', ['src/**/*.scss', '--config', 'stylelint-config.json', '--syntax', 'scss']