Skip to content

Commit f28af4b

Browse files
committed
fix(material/dialog): using incorrect mixin for structural styles
The MDC dialog was using the `core-styles` mixin instead of the `static-styles` which is supposed to be used together with the new theming API. I've also removed the `container-elevation` and `container-shadow-color` variables from the theme since they weren't doing anything.
1 parent 3960e4f commit f28af4b

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/material/dialog/_dialog-theme.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919

2020
@include mdc-dialog-theme.theme((
2121
container-color: $surface,
22-
container-elevation: 24,
23-
container-shadow-color: $on-surface,
2422
with-divider-divider-color: rgba($on-surface, mdc-dialog.$scroll-divider-opacity),
2523
subhead-color: rgba($on-surface, $text-emphasis-high),
2624
supporting-text-color: rgba($on-surface, $text-emphasis-medium),

src/material/dialog/dialog.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@use '@material/dialog' as mdc-dialog;
2+
@use '@material/dialog/variables' as mdc-dialog-variables;
23
@use '@material/dialog/dialog-theme' as mdc-dialog-theme;
34
@use './mdc-dialog-structure-overrides';
45
@use '../core/mdc-helpers/mdc-helpers';
@@ -26,6 +27,9 @@ $_dialog-initial-theme: (
2627
supporting-text-size: 14px,
2728
supporting-text-weight: 500,
2829
supporting-text-tracking: 1px,
30+
31+
// Structure
32+
container-shape: mdc-dialog-variables.$shape-radius,
2933
);
3034

3135
// Dialog content max height. This has been copied from the standard dialog
@@ -36,7 +40,7 @@ $mat-dialog-content-max-height: 65vh !default;
3640
$mat-dialog-button-horizontal-margin: 8px !default;
3741

3842
@include mdc-helpers.disable-mdc-fallback-declarations {
39-
@include mdc-dialog.core-styles($query: mdc-helpers.$mdc-base-styles-query);
43+
@include mdc-dialog.static-styles($query: mdc-helpers.$mdc-base-styles-query);
4044
}
4145

4246
@include mdc-dialog-structure-overrides.private-dialog-structure-overrides(

0 commit comments

Comments
 (0)