build: update angular shared dev-infra code to 932b9d5 (#25000)

* build: update angular shared dev-infra package

Updates the shared dev-infra package.

* build: use new release prechecks for validating release before publish

Uses the new release precheck feature for validating release output
and other inputs.

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Paul Gschwendtner <[email protected]>
(cherry picked from commit 2740e98)

Author: 3 people

.ng-dev/release.ts

@@ -1,63 +1,8 @@
-import {
-  BuiltPackage,
-  ReleaseConfig,
-  ReleaseAction as _ReleaseAction,
-  FatalReleaseActionError,
-} from '@angular/dev-infra-private/ng-dev';
 import {SemVer} from 'semver';
+import {ReleaseConfig} from '@angular/dev-infra-private/ng-dev';
+import {assertValidFrameworkPeerDependency} from '../tools/release-checks/check-framework-peer-dependency';
+import {assertValidUpdateMigrationCollections} from '../tools/release-checks/check-migration-collections';
 import {assertValidNpmPackageOutput} from '../tools/release-checks/npm-package-output';
-import {fork} from 'child_process';
-import {join} from 'path';
-
-// The `ng-dev` release tool exposes the `ReleaseAction` instance through `global`,
-// allowing it to be monkey-patched for our release checks. This can be removed
-// when the release tool has a public API for release checks.
-const actionProto = ((global as any).ReleaseAction ?? _ReleaseAction).prototype;
-const _origStageFn = actionProto.stageVersionForBranchAndCreatePullRequest;
-const _origVerifyFn = actionProto._verifyPackageVersions;
-
-/** Runs the staging sanity release checks for the given new version. */
-async function runStagingReleaseChecks(newVersion: SemVer) {
-  return new Promise<void>((resolve, reject) => {
-    // Note: We run the staging release checks in a new node process. This is necessary
-    // because before staging, the correct publish branch is checked out. If we'd
-    // directly call into the release checks, the `.ng-dev/release` config would be
-    // cached by NodeJS and release checks would potentially check for packages which
-    // no longer exist in the publish branch (or the other way around).
-    const releaseChecksProcess = fork(join(__dirname, '../tools/release-checks/index.js'), [
-      newVersion.format(),
-    ]);
-
-    releaseChecksProcess.on('close', code => {
-      if (code !== 0) {
-        reject(new FatalReleaseActionError());
-      } else {
-        resolve();
-      }
-    });
-  });
-}
-
-// Patches the `@angular/dev-infra-private` release tool to perform sanity checks
-// before staging a release. This is temporary until the dev-infra team has implemented
-// a more generic solution to running sanity checks before releasing (potentially building
-// some of the checks we have in the components repository into the release tool).
-actionProto.stageVersionForBranchAndCreatePullRequest = async function (newVersion: SemVer) {
-  await runStagingReleaseChecks(newVersion);
-
-  return await _origStageFn.apply(this, arguments);
-};
-
-// Patches the `@angular/dev-infra-private` release tool to perform sanity
-// checks of the NPM package output, before publishing to NPM.
-actionProto._verifyPackageVersions = async function (
-  newVersion: SemVer,
-  builtPackages: BuiltPackage[],
-) {
-  await assertValidNpmPackageOutput(builtPackages, newVersion);
-
-  return await _origVerifyFn.apply(this, arguments);
-};
 
 /**
  * Packages that will be published as part of the project.
@@ -104,4 +49,11 @@ export const release: ReleaseConfig = {
     const {performNpmReleaseBuild} = await import('../scripts/build-packages-dist');
     return performNpmReleaseBuild();
   },
+  prereleaseCheck: async (newVersionStr, builtPackagesWithInfo) => {
+    const newVersion = new SemVer(newVersionStr);
+
+    await assertValidFrameworkPeerDependency(newVersion);
+    await assertValidUpdateMigrationCollections(newVersion);
+    await assertValidNpmPackageOutput(builtPackagesWithInfo, newVersion);
+  },
 };

package.json

@@ -75,7 +75,7 @@
     "@angular/bazel": "14.0.0-next.9",
     "@angular/cli": "13.3.0",
     "@angular/compiler-cli": "13.3.0",
-    "@angular/dev-infra-private": "https://github.com/angular/dev-infra-private-builds.git#04424ec1cd38a1d12786ffdaa8005645e6640687",
+    "@angular/dev-infra-private": "https://github.com/angular/dev-infra-private-builds.git#932b9d5f6227d1a2dfa2a416fa317c2e55584994",
     "@angular/localize": "13.3.0",
     "@angular/platform-browser-dynamic": "13.3.0",
     "@angular/platform-server": "13.3.0",

tools/release-checks/check-framework-peer-dependency.ts

@@ -1,4 +1,4 @@
-import {error, FatalReleaseActionError} from '@angular/dev-infra-private/ng-dev';
+import {error, ReleasePrecheckError} from '@angular/dev-infra-private/ng-dev';
 import {SemVer} from 'semver';
 import {join} from 'path';
 import {existsSync, readFileSync} from 'fs';
@@ -29,7 +29,7 @@ export async function assertValidFrameworkPeerDependency(newVersion: SemVer) {
       ),
     );
     error(chalk.red(`      Please manually update the version range ` + `in: ${bzlConfigPath}`));
-    throw new FatalReleaseActionError();
+    throw new ReleasePrecheckError();
   }
 }
 
@@ -45,7 +45,7 @@ function _extractAngularVersionPlaceholderOrThrow(): string {
           `the Angular peerDependency placeholder value. Looked for: ${bzlConfigPath}`,
       ),
     );
-    throw new FatalReleaseActionError();
+    throw new ReleasePrecheckError();
   }
 
   const configFileContent = readFileSync(bzlConfigPath, 'utf8');
@@ -58,7 +58,7 @@ function _extractAngularVersionPlaceholderOrThrow(): string {
           `Looked in: ${bzlConfigPath}`,
       ),
     );
-    throw new FatalReleaseActionError();
+    throw new ReleasePrecheckError();
   }
   return matches[1];
 }

tools/release-checks/check-migration-collections.ts

@@ -1,8 +1,8 @@
-import {error} from '@angular/dev-infra-private/ng-dev';
+import {error, ReleasePrecheckError} from '@angular/dev-infra-private/ng-dev';
+import {readFileSync} from 'fs';
 import {dirname, join} from 'path';
-import chalk from 'chalk';
 import {releasePackages} from '../../.ng-dev/release';
-import {readFileSync} from 'fs';
+import chalk from 'chalk';
 import semver from 'semver';
 
 /** Path to the directory containing all package sources. */
@@ -21,7 +21,7 @@ export async function assertValidUpdateMigrationCollections(newVersion: semver.S
   if (failures.length) {
     error(chalk.red(`  ✘   Failures in ng-update migration collection detected:`));
     failures.forEach(f => error(f));
-    process.exit(1);
+    throw new ReleasePrecheckError();
   }
 }
 

tools/release-checks/npm-package-output/index.ts

@@ -1,6 +1,6 @@
 import {SemVer} from 'semver';
 import {checkReleasePackage} from './check-package';
-import {BuiltPackage, error} from '@angular/dev-infra-private/ng-dev';
+import {BuiltPackage, error, ReleasePrecheckError} from '@angular/dev-infra-private/ng-dev';
 import chalk from 'chalk';
 
 /** Asserts that the given built packages are valid for public consumption. */
@@ -16,6 +16,6 @@ export async function assertValidNpmPackageOutput(
 
   if (!passing) {
     error(chalk.red(`  ✘   NPM package output does not pass all release validations.`));
-    process.exit(1);
+    throw new ReleasePrecheckError();
   }
 }