Skip to content

Commit f556fae

Browse files
committed
ensure change detection completes even if test code throws
1 parent dbdbfb4 commit f556fae

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

src/cdk/testing/change-detection.ts

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,21 @@ async function batchChangeDetection<T>(fn: () => Promise<T>, triggerBeforeAndAft
7777
isDisabled: true,
7878
onDetectChangesNow: resolve,
7979
}));
80-
const result = await fn();
81-
await new Promise(resolve => autoChangeDetectionSubject.next({
82-
isDisabled: false,
83-
onDetectChangesNow: resolve,
84-
}));
85-
return result;
80+
try {
81+
return await fn();
82+
} finally {
83+
await new Promise(resolve => autoChangeDetectionSubject.next({
84+
isDisabled: false,
85+
onDetectChangesNow: resolve,
86+
}));
87+
}
8688
} else {
8789
autoChangeDetectionSubject.next({isDisabled: true});
88-
const result = await fn();
89-
autoChangeDetectionSubject.next({isDisabled: false});
90-
return result;
90+
try {
91+
return await fn();
92+
} finally {
93+
autoChangeDetectionSubject.next({isDisabled: false});
94+
}
9195
}
9296
}
9397

0 commit comments

Comments
 (0)