Skip to content

Commit f5d9555

Browse files
devversionandrewseguin
authored andcommitted
fixup! build: replace setup angular snapshots script with python script
Add comment explaining why script needs to be in python
1 parent 16a8775 commit f5d9555

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

scripts/circleci/setup-angular-snapshots.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,13 @@
1212
to flatten **all** dependencies and could cause unexpected results. We **only** want to
1313
explicitly flatten out all `@angular/*` dependencies. This can be achieved with resolutions.
1414
Read more here: https://yarnpkg.com/lang/en/docs/package-json/#toc-resolutions
15+
16+
**Note** that this script has to be written in Python because the docker container which
17+
is used for our CI does not come with NodeJS pre-installed. Since this script needs to run
18+
before the Bazel analysis phase is started, we can only run this script only with tools that
19+
are pre-installed in the image. Python is a pre-installed in the google/bazel official image
20+
and therefore we use that for the "package.json" modification. Note that this script is only
21+
running on CI and therefore there are no implications with writing this in python.
1522
"""
1623

1724
import json

0 commit comments

Comments
 (0)