Skip to content

Commit f8b51e6

Browse files
committed
fix lint and address feedback
1 parent 1cf98a7 commit f8b51e6

File tree

3 files changed

+9
-61
lines changed

3 files changed

+9
-61
lines changed

.github/CODEOWNERS

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,19 +176,26 @@
176176
/src/e2e-app/* @jelbourn
177177
/src/e2e-app/block-scroll-strategy/** @andrewseguin @crisbeto
178178
/src/e2e-app/button/** @jelbourn
179+
/src/e2e-app/button-toggle/** @jelbourn
180+
/src/e2e-app/card/** @jelbourn
179181
/src/e2e-app/checkbox/** @jelbourn @devversion
180182
/src/e2e-app/dialog/** @jelbourn @crisbeto
181183
/src/e2e-app/e2e-app/** @jelbourn
184+
/src/e2e-app/example-viewer/** @andrewseguin
185+
/src/e2e-app/expansion/** @josephperrott
182186
/src/e2e-app/grid-list/** @jelbourn
183187
/src/e2e-app/icon/** @jelbourn
184188
/src/e2e-app/input/** @mmalerba
189+
/src/e2e-app/list/** @jelbourn
185190
/src/e2e-app/menu/** @crisbeto
186191
/src/e2e-app/progress-bar/** @jelbourn @crisbeto @josephperrott
187192
/src/e2e-app/progress-spinner/** @jelbourn @crisbeto @josephperrott
188193
/src/e2e-app/radio/** @jelbourn @devversion
189194
/src/e2e-app/sidenav/** @mmalerba
190195
/src/e2e-app/slide-toggle/** @devversion
196+
/src/e2e-app/stepper/** @mmalerba
191197
/src/e2e-app/tabs/** @andrewseguin
198+
/src/e2e-app/toolbar/** @devversion
192199
/src/e2e-app/virtual-scroll/** @mmalerba
193200

194201
# Universal app

src/e2e-app/example-viewer/example-list-viewer.component.ts

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -8,34 +8,12 @@
88

99
import {Component, Input} from '@angular/core';
1010

11-
/** Displays a set of material examples in a mat-accordion. */
11+
/** Loads an example component from `@angular/material-examples`. */
1212
@Component({
1313
selector: 'example-list-viewer',
1414
template: `
1515
<example-viewer *ngFor="let id of ids" [id]="id"></example-viewer>
1616
`,
17-
styles: [`
18-
mat-expansion-panel {
19-
box-shadow: none !important;
20-
border-radius: 0 !important;
21-
background: transparent;
22-
border-top: 1px solid #CCC;
23-
}
24-
25-
.header {
26-
display: flex;
27-
justify-content: space-between;
28-
width: 100%;
29-
padding-right: 24px;
30-
align-items: center;
31-
}
32-
33-
.id {
34-
font-family: monospace;
35-
color: #666;
36-
font-size: 12px;
37-
}
38-
`]
3917
})
4018
export class ExampleListViewer {
4119
/** IDs of the examples to display. */

src/e2e-app/example-viewer/example-viewer.ts

Lines changed: 1 addition & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -6,59 +6,23 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {coerceBooleanProperty} from '@angular/cdk/coercion';
109
import {Component, ElementRef, Injector, Input, OnInit} from '@angular/core';
1110
import {createCustomElement} from '@angular/elements';
1211
import {EXAMPLE_COMPONENTS} from '@angular/material-examples';
1312

13+
/** Loads an example component from `@angular/material-examples` */
1414
@Component({
1515
selector: 'example-viewer',
1616
template: `
17-
<div class="label" *ngIf="showLabel">
18-
<span class="title"> {{title}} </span>
19-
<span class="id"> <{{id}}> </span>
20-
</div>
21-
2217
<div *ngIf="!id">
2318
Could not find example {{id}}
2419
</div>
2520
`,
26-
styles: [`
27-
.label {
28-
display: flex;
29-
justify-content: space-between;
30-
align-items: flex-end;
31-
margin: 16px 0;
32-
}
33-
34-
.title {
35-
font-size: 20px;
36-
font-weight: 500;
37-
}
38-
39-
.id {
40-
font-size: 13px;
41-
font-family: monospace;
42-
color: #666;
43-
white-space: pre;
44-
}
45-
`]
4621
})
4722
export class ExampleViewer implements OnInit {
4823
/** ID of the material example to display. */
4924
@Input() id: string;
5025

51-
@Input()
52-
get showLabel(): boolean {
53-
return this._showLabel;
54-
}
55-
set showLabel(v: boolean) {
56-
this._showLabel = coerceBooleanProperty(v);
57-
}
58-
_showLabel: boolean;
59-
60-
title: string;
61-
6226
constructor(private _elementRef: ElementRef<HTMLElement>, private _injector: Injector) {}
6327

6428
ngOnInit() {
@@ -72,6 +36,5 @@ export class ExampleViewer implements OnInit {
7236
}
7337

7438
this._elementRef.nativeElement.appendChild(new exampleElementCtor(this._injector));
75-
this.title = EXAMPLE_COMPONENTS[this.id] ? EXAMPLE_COMPONENTS[this.id].title : '';
7639
}
7740
}

0 commit comments

Comments
 (0)