fixup! fix(material/list): Do not rely on input binding order

Author: atscott

src/material/list/selection-list.spec.ts

@@ -39,6 +39,7 @@ describe('MatSelectionList without forms', () => {
           SelectionListWithListDisabled,
           SelectionListWithOnlyOneOption,
           SelectionListWithIndirectChildOptions,
+          SelectionListWithSelectedOptionAndValue,
         ],
       });
 
@@ -594,6 +595,14 @@ describe('MatSelectionList without forms', () => {
             .toBe(0, 'Expected no ripples after list ripples are disabled.');
       }));
 
+    it('can bind both selected and value at the same time', () => {
+      const fixture = TestBed.createComponent(SelectionListWithSelectedOptionAndValue);
+      fixture.detectChanges();
+      const listItemEl = fixture.debugElement.query(By.directive(MatListOption))!;
+      expect(listItemEl.componentInstance.selected).toBe(true);
+      expect(listItemEl.componentInstance.value).toBe(fixture.componentInstance.itemValue);
+    });
+
   });
 
   describe('with list option selected', () => {
@@ -1191,18 +1200,6 @@ describe('MatSelectionList with forms', () => {
       expect(testComponent.optionInstances.toArray()[1].selected).toBe(true);
     }));
   });
-
-  it('can bind both selected and value at the same time', () => {
-    const fixture =
-        TestBed
-            .configureTestingModule(
-                {imports: [MatListModule], declarations: [SelectionListWithSelectedOptionAndValue]})
-            .createComponent(SelectionListWithSelectedOptionAndValue);
-    fixture.detectChanges();
-    const listItemEl = fixture.debugElement.query(By.directive(MatListOption))!;
-    expect(listItemEl.componentInstance.selected).toBe(true);
-    expect(listItemEl.componentInstance.value).toBe(fixture.componentInstance.itemValue);
-  });
 });
 
 

src/material/list/selection-list.ts

@@ -116,9 +116,8 @@ export class MatSelectionListChange {
   encapsulation: ViewEncapsulation.None,
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
-export class MatListOption extends _MatListOptionMixinBase implements AfterContentInit, OnChanges,
-                                                                      OnDestroy, OnInit,
-                                                                      FocusableOption,
+export class MatListOption extends _MatListOptionMixinBase implements AfterContentInit, OnDestroy,
+                                                                      OnInit, FocusableOption,
                                                                       CanDisableRipple {
   private _selected = false;
   private _disabled = false;
@@ -208,9 +207,6 @@ export class MatListOption extends _MatListOptionMixinBase implements AfterConte
         this._changeDetector.markForCheck();
       }
     });
-  }
-
-  ngOnChanges() {
     this._inputsInitialized = true;
   }