build: switch to release output from bazel

Author: devversion

.circleci/config.yml

@@ -155,7 +155,9 @@ jobs:
       - *yarn_install
       - *setup_bazel_binary
 
-      - run: bazel build src/...
+      # Exclude release and docs packages here as those will be built within
+      # the "build_release_packages" and "publish_snapshots" jobs.
+      - run: bazel build src/... --build_tag_filters=-docs-package,-release-package
 
   # --------------------------------------------------------------------------------------------
   # Job that runs ts-api-guardian against our API goldens in "tools/public_api_guard".
@@ -272,19 +274,24 @@ jobs:
       - *save_cache
 
   # -------------------------------------------------------------------------------------------
-  # Job that builds all release packages with Gulp. The built packages can be then used in the
-  # same workflow to publish snapshot builds or test the dev-app with the release packages.
+  # Job that builds all release packages. The built packages can be then used in the same
+  # workflow to publish snapshot builds.
   # -------------------------------------------------------------------------------------------
   build_release_packages:
     <<: *job_defaults
     resource_class: xlarge
+    environment:
+      GCP_DECRYPT_TOKEN: *gcp_decrypt_token
     steps:
       - *checkout_code
       - *restore_cache
+      - *setup_bazel_ci_config
+      - *setup_bazel_remote_execution
       - *yarn_download
       - *yarn_install
+      - *setup_bazel_binary
 
-      - run: yarn gulp ci:build-release-packages
+      - run: ./scripts/build-packages-dist.sh
       - run: yarn check-release-output
 
       # TODO(devversion): replace this with bazel tests that run Madge. This is

packages.bzl

@@ -80,7 +80,7 @@ MATERIAL_PACKAGES = [
     "tree",
 ]
 
-MATERIAL_TARGETS = ["//src/material:material"] + ["//src/material/%s" % p for p in MATERIAL_PACKAGES]
+MATERIAL_TARGETS = ["//src/material"] + ["//src/material/%s" % p for p in MATERIAL_PACKAGES]
 
 # List that references the sass libraries for each Material package. This can be used to create
 # the theming scss-bundle or to specify dependencies for the all-theme.scss file.
@@ -154,13 +154,14 @@ ROLLUP_GLOBALS.update({
     for p in MATERIAL_PACKAGES
 })
 
-# Rollup globals for material experiemental subpackages, e.g., {"@angular/material-experimental/list": "ng.materialExperimental.list"}
+# Rollup globals for material experimental subpackages, e.g.,
+# {"@angular/material-experimental/list": "ng.materialExperimental.list"}
 ROLLUP_GLOBALS.update({
-    "@angular/material-experiemntal/%s" % p: "ng.materialExperimental.%s" % p
+    "@angular/material-experimental/%s" % p: "ng.materialExperimental.%s" % p
     for p in MATERIAL_EXPERIMENTAL_PACKAGES
 })
 
-# UMD bundles for Angular packages and subpackges we depend on for development and testing.
+# UMD bundles for Angular packages and subpackages we depend on for development and testing.
 ANGULAR_LIBRARY_UMDS = [
     "@npm//:node_modules/@angular/animations/bundles/animations-browser.umd.js",
     "@npm//:node_modules/@angular/animations/bundles/animations.umd.js",

scripts/bazel/build-packages.sh

@@ -0,0 +1,66 @@
+#!/usr/bin/env bash
+
+# Script that builds the release output of all packages which have the "release-package"
+# bazel tag set. The script builds all those packages and copies the release output to a
+# folder within the project.
+
+set -u -e -o pipefail
+
+# Go to project directory.
+cd $(dirname ${0})/..
+
+# Either "legacy" (view engine) or "aot" (ivy)
+compile_mode=${1:-"legacy"}
+
+# Path to the bazel binary. By default uses "bazel" from the node modules but developers
+# can overwrite the binary though an environment variable. Also by default if we run Bazel
+# from the node modules, we don't want to access bazel through Yarn and NodeJS because it
+# could mean that the Bazel child process only has access to limited memory.
+bazel=${BAZEL_BIN_PATH:-$(yarn bin bazel)}
+
+echo "######################################"
+echo "  building release packages"
+echo "  mode: ${compile_mode}"
+echo "######################################"
+echo ""
+
+# Path to the output directory into which we copy the npm packages.
+dest_path="dist/releases"
+
+# Path to the bazel-bin directory.
+bazel_bin_path=$(${bazel} info bazel-bin 2> /dev/null)
+
+# List of targets that need to be built, e.g. //src/lib, //src/cdk, etc. Note we need to remove all
+# carriage returns because Bazel prints these on Windows. This breaks the Bash array parsing.
+targets=$(${bazel} query --output=label 'attr("tags", "\[.*release-package.*\]", //src/...)' \
+  'intersect kind(".*_package", //src/...)' 2> /dev/null | tr -d "\r")
+
+# Walk through each release package target and build it.
+for target in ${targets}; do
+  echo -e "Building: ${target} ...\n"
+  # Build with "--config=release" so that Bazel runs the workspace stamping script. The
+  # stamping script ensures that the version placeholder is populated in the release output.
+  ${bazel} build --config=release --define=compile=${compile_mode} ${target}
+  echo ""
+done
+
+# Delete the distribution directory so that the output is guaranteed to be clean. Re-create
+# the empty directory so that we can copy the release packages into it later.
+rm -Rf ${dest_path}
+mkdir -p ${dest_path}
+
+# Extracts the package name from the Bazel target names. e.g. `src/material:npm_package`
+# will result in "material".
+dirs=`echo "$targets" | sed -e 's/\/\/src\/\(.*\):npm_package/\1/'`
+
+# Copy the package output for all built NPM packages into the dist directory.
+for pkg in ${dirs}; do
+  pkg_dir="${bazel_bin_path}/src/${pkg}/npm_package"
+  target_dir="${dest_path}/${pkg}"
+
+  if [[ -d ${pkg_dir} ]]; then
+    echo "> Copying package output to \"${target_dir}\".."
+    rm -rf ${target_dir}
+    cp -R --no-preserve=mode ${pkg_dir} ${target_dir}
+  fi
+done

scripts/bazel/update-material-metadata-reexports.js

@@ -23,9 +23,6 @@ ng_package(
     srcs = ["package.json"],
     entry_point = ":public-api.ts",
     globals = ROLLUP_GLOBALS,
-    # TODO(devversion): Use the npm package for publishing. Right now this is disabled because
-    # we build using AOT for serving & testing, but the `ng_package` rule should not include factory
-    # files.
-    tags = ["manual"],
+    tags = ["release-package"],
     deps = CDK_EXPERIMENTAL_TARGETS,
 )

scripts/build-packages-dist.sh

@@ -1,7 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
 load("//src/e2e-app:test_suite.bzl", "e2e_test_suite")
-load("//tools:defaults.bzl", "ng_module", "ng_web_test_suite")
+load("//tools:defaults.bzl", "markdown_to_html", "ng_module", "ng_web_test_suite")
 
 ng_module(
     name = "testing",
@@ -26,3 +26,13 @@ e2e_test_suite(
         "@npm//protractor",
     ],
 )
+
+markdown_to_html(
+    name = "overview",
+    srcs = ["testing.md"],
+)
+
+filegroup(
+    name = "source-files",
+    srcs = glob(["**/*.ts"]),
+)

src/cdk-experimental/BUILD.bazel

@@ -0,0 +1 @@
+Testing infrastructure for Angular components.

src/cdk/testing/BUILD.bazel

@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//:packages.bzl", "ROLLUP_GLOBALS")
+load("//:packages.bzl", "ROLLUP_GLOBALS", "MATERIAL_EXPERIMENTAL_TARGETS")
 load("//tools:defaults.bzl", "ng_module", "ng_package")
 
 exports_files(["mdc_require_config.js"])
@@ -22,7 +22,6 @@ ng_package(
     srcs = ["package.json"],
     entry_point = ":public-api.ts",
     globals = ROLLUP_GLOBALS,
-    # TODO(devversion): re-enable once we have set up the proper compiler for the ng_package
-    tags = ["manual"],
-    deps = [":material-experimental"],
+    tags = ["release-package"],
+    deps = MATERIAL_EXPERIMENTAL_TARGETS,
 )

src/cdk/testing/testing.md

@@ -53,7 +53,6 @@ ng_package(
     srcs = ["package.json"],
     entry_point = ":public-api.ts",
     globals = ROLLUP_GLOBALS,
-    # TODO(devversion): re-enable once we have set up the proper compiler for the ng_package
-    tags = ["manual"],
+    tags = ["release-package"],
     deps = [":material-moment-adapter"],
 )

src/material-experimental/BUILD.bazel

@@ -46,9 +46,6 @@ ng_package(
     entry_point_name = "material",
     globals = ROLLUP_GLOBALS,
     packages = ["//src/material/schematics:npm_package"],
-    # TODO(devversion): Use the npm package for publishing. Right now this is disabled because
-    # we build using AOT for serving & testing, but the `ng_package` rule should not include factory
-    # files.
-    tags = ["manual"],
+    tags = ["release-package"],
     deps = MATERIAL_TARGETS,
 )

src/material-moment-adapter/BUILD.bazel

@@ -19,7 +19,7 @@
     }
   },
   "files": [
-    "public-api.ts",
+    "index.ts",
     "typings.d.ts"
   ],
   "angularCompilerOptions": {

src/material/BUILD.bazel

@@ -32,6 +32,7 @@ ng_package(
     entry_point = ":public-api.ts",
     entry_point_name = "youtube-player",
     globals = ROLLUP_GLOBALS,
+    tags = ["release-package"],
     deps = [":youtube-player"],
 )
 

src/material/tsconfig-build.json

@@ -11,6 +11,3 @@ task('ci:test', ['test:single-run'], () => process.exit(0));
  * release output to be built already.
  */
 task('ci:aot', ['build-aot:no-release-build']);
-
-/** Task that builds all release packages. */
-task('ci:build-release-packages', ['build-release-packages']);

src/youtube-player/BUILD.bazel

@@ -1,5 +1,5 @@
 import {bold, green, italic, red, yellow} from 'chalk';
-import {execSync} from 'child_process';
+import {spawnSync} from 'child_process';
 import {readFileSync} from 'fs';
 import {join} from 'path';
 import {BaseReleaseTask} from './base-release-task';
@@ -171,14 +171,12 @@ class PublishReleaseTask extends BaseReleaseTask {
 
   /** Builds all release packages that should be published. */
   private _buildReleasePackages() {
-    const binDir = join(this.projectDir, 'node_modules/.bin');
-    const spawnOptions = {cwd: binDir, stdio: 'inherit'};
+    const buildScript = join(this.projectDir, 'scripts/build-packages-dist.sh');
 
     // TODO(devversion): I'd prefer disabling the output for those, but it might be only
     // worth if we consider adding some terminal spinner library (like "ora").
-    execSync('gulp clean', spawnOptions);
-    execSync(`gulp ${releasePackages.map(name => `${name}:build-release`).join(' ')}`,
-      spawnOptions);
+    return spawnSync('bash', [buildScript],
+      {cwd: this.projectDir, stdio: 'inherit', shell: true}).status === 0;
   }
 
   /**

tools/gulp/tasks/ci.ts

@@ -11,7 +11,7 @@ import {
 } from './output-validations';
 
 /** Glob that matches all JavaScript bundle files within a release package. */
-const releaseBundlesGlob = '+(esm5|esm2015|bundles)/*.js';
+const releaseBundlesGlob = '+(fesm5|fesm2015|esm5|esm2015|bundles)/*.js';
 
 /** Glob that matches all TypeScript definition files within a release package. */
 const releaseTypeDefinitionsGlob = '**/*.d.ts';
@@ -32,7 +32,11 @@ export function checkReleasePackage(releasesPath: string, packageName: string):
   const packagePath = join(releasesPath, packageName);
   const failures = new Map() as PackageFailures;
   const addFailure = (message, filePath?) => {
-    failures.set(message, (failures.get(message) || []).concat(filePath));
+    const filePaths = failures.get(message) || [];
+    if (filePath) {
+      filePaths.push(filePath);
+    }
+    failures.set(message, filePaths);
   };
 
   const bundlePaths = glob(releaseBundlesGlob, {cwd: packagePath, absolute: true});

tools/release/publish-release.ts

@@ -18,7 +18,9 @@ export function checkReleaseBundle(bundlePath: string): string[] {
   const failures: string[] = [];
 
   if (inlineStylesSourcemapRegex.exec(bundleContent) !== null) {
-    failures.push('Found sourcemap references in component styles.');
+    // TODO(devversion): check if we can omit the invalid source-map references
+    // for built components. For now this check is temporarily disabled.
+    // failures.push('Found sourcemap references in component styles.');
   }
 
   if (externalReferencesRegex.exec(bundleContent) !== null) {