Skip to content

docs(datepicker): typos #10339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2018
Merged

docs(datepicker): typos #10339

merged 2 commits into from
Mar 9, 2018

Conversation

julianobrasil
Copy link
Contributor

Fixes some typos in datepicker docs.

@julianobrasil julianobrasil requested a review from mmalerba as a code owner March 9, 2018 09:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 9, 2018
and `monthSelected` outputs emit a normalized date representing the chosen year or month. By
"normalized" we mean that the dates representing a year will have their month set to January and
their day set to the 1st. Dates representing months will have their day set to the 1st of the
their day set to the 1st. Dates representing a month will have their day set to the 1st of that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this one was correct to begin with.

Copy link
Contributor Author

@julianobrasil julianobrasil Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'll change the previous sentence from "a year" to "years" too. Is that what you mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, it would be like this:

... the dates representing years will have their month set to January and their day set to the 1st. Dates representing months will have their day set to the 1st of the ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 9, 2018
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Mar 9, 2018
@jelbourn jelbourn merged commit 0a619e9 into angular:master Mar 9, 2018
@julianobrasil julianobrasil deleted the fixTypos branch March 30, 2018 11:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants