build: add schematics to @angular/material package #10351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Closed
jelbourn
force-pushed
the
schematics-home
branch
from
e6d98cc to
a2c25ae
Compare
crisbeto
approved these changes
Mar 10, 2018
| @@ -16,7 +16,6 @@ import { | |||
| } from '@angular-devkit/schematics'; | |||
| import 'rxjs/add/operator/merge'; | |||
| import * as ts from 'typescript'; | |||
| import * as stringUtils from '@schematics/angular/strings'; | |||
| import { addDeclarationToModule, addExportToModule } from './ast-utils'; | |||
There was a problem hiding this comment.
Not something that was added in this PR, but the spaces between the curly braces are inconsistent with the rest of the project.
tools/gulp/tasks/material-release.ts
Outdated
| */ | ||
| task('material:prepare-release', sequenceTask( | ||
| 'material:build', | ||
| ['material:copy-prebuilt-themes', 'material:bundle-theming-scss'] | ||
| ['material:build', "schematics:build"], |
There was a problem hiding this comment.
schematics:build should be in single quotes.
tools/gulp/tasks/material-release.ts
Outdated
| )); | ||
|
|
||
| task('material:copy-schematics', () => { | ||
| src(schematicsGlobs).pipe(dest(join(join(releasePath, 'schematics')))); |
There was a problem hiding this comment.
The second join around the first join seems unnecessary.
jelbourn
force-pushed
the
schematics-home
branch
from
a2c25ae to
342e130
Compare
jelbourn
force-pushed
the
schematics-home
branch
2 times, most recently
from
a4a7c85 to
a9aa88d
Compare
This also fixes a handful of minor issues with the blueprints
jelbourn
force-pushed
the
schematics-home
branch
from
a9aa88d to
1fc7dcf
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a handful of minor issues with the blueprints