Skip to content

fix(datepicker): high contrast accessibility improvements #10363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2018

Conversation

crisbeto
Copy link
Member

Adds a few improvements to the datepicker calendar in high contrast mode:

  • Adds an outline around the calendar in popup, in order to make it stand out against the background.
  • Fixes all of the dates appearing as selected due to their border.
  • Adds an outline only around the selected date and a dotted outline against the current date.

@crisbeto crisbeto added pr: needs review Accessibility This issue is related to accessibility (a11y) labels Mar 11, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner March 11, 2018 14:21
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 11, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Mar 12, 2018
Adds a few improvements to the datepicker calendar in high contrast mode:

* Adds an outline around the calendar in popup, in order to make it stand out against the background.
* Fixes all of the dates appearing as selected due to their border.
* Adds an outline only around the selected date and a dotted outline against the current date.
@crisbeto crisbeto force-pushed the datepicker-calendar-mode branch from c70cd9e to d50a624 Compare April 15, 2018 20:34
@mmalerba mmalerba merged commit 4d23b08 into angular:master Apr 16, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants