Skip to content

fix(menu): not closing sibling sub-menus when hovering over disabled items #10396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2018
Merged

fix(menu): not closing sibling sub-menus when hovering over disabled items #10396

merged 1 commit into from
Apr 19, 2018

Conversation

crisbeto
Copy link
Member

  • Fixes sub-menus not being closed when the user hovers over a disabled sibling menu item.
  • Fixes the sub-menu arrow not being greyed out for disabled items.

@crisbeto crisbeto requested a review from kara as a code owner March 13, 2018 11:38
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2018
jelbourn
jelbourn approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Mar 13, 2018
@crisbeto crisbeto removed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 13, 2018
@crisbeto
Copy link
Member Author

Just noticed that Firefox is failing. Removing the release and ready labels until it's fixed.

@crisbeto
fix(menu): not closing sibling sub-menus when hovering over disabled …
fdfe3c8 
…items

* Fixes sub-menus not being closed when the user hovers over a disabled sibling menu item.
* Fixes the sub-menu arrow not being greyed out for disabled items.
@crisbeto crisbeto force-pushed the disabled-nested-menu branch from d57f242 to fdfe3c8 Compare March 13, 2018 21:31
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 13, 2018
@mmalerba mmalerba merged commit 3b7fe64 into angular:master Apr 19, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @mmalerba