fix(overlay): incorrect bounding box styles if position is exactly zero #10470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Mar 19, 2018
| .getContainerElement() | ||
| .querySelector('.cdk-overlay-connected-position-bounding-box') as HTMLElement; | ||
|
|
||
| expect(boundingBox.style.bottom).toBe('0px'); |
There was a problem hiding this comment.
Add comment for these tests like "Ensure that 0px is explicitly set rather than the property being left blank due to zero being falsy."
jelbourn
added
P1
crisbeto
force-pushed
the
flexible-overlay-zero-position
branch
from
d35ce47 to
731ba44
Compare
Handles the edge case where the bounding box styles won't be set correctly, causing the overlay to jump to a wrong position, if either of its values works out to exactly zero.
crisbeto
force-pushed
the
flexible-overlay-zero-position
branch
from
731ba44 to
b2ed8e4
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the edge case where the bounding box styles won't be set correctly, causing the overlay to jump to a wrong position, if either of its values works out to exactly zero.