Skip to content

fix(button-toggle): focus monitoring not being cleaned up on destroy #10580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2018
Merged

fix(button-toggle): focus monitoring not being cleaned up on destroy #10580

merged 1 commit into from
Apr 13, 2018

Conversation

crisbeto
Copy link
Member

Fixes the focus monitoring for the individual buttons toggles not being cleaned up when they're destroyed, causing the reference to stay inside the FocusMonitor.

@crisbeto crisbeto requested a review from tinayuangao as a code owner March 26, 2018 21:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 26, 2018
tinayuangao
tinayuangao approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Mar 27, 2018
@jelbourn
Copy link
Member

jelbourn commented Apr 6, 2018

Looks like this has some CI failures

@crisbeto
fix(button-toggle): focus monitoring not being cleaned up on destroy
7454dca 
Fixes the focus monitoring for the individual buttons toggles not being cleaned up when they're destroyed, causing the reference to stay inside the `FocusMonitor`.
@crisbeto crisbeto force-pushed the button-toggle-focus-monitoring-cleanup branch from 4d66884 to 7454dca Compare April 7, 2018 09:16
@crisbeto
Copy link
Member Author

crisbeto commented Apr 7, 2018

Those look like they came in from master. I've rebased it.

@tinayuangao tinayuangao merged commit c9651bb into angular:master Apr 13, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinayuangao tinayuangao tinayuangao approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @tinayuangao @googlebot