fix(paginator): getNumberOfPages off by one #10724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Apr 5, 2018
src/lib/paginator/paginator.ts
Outdated
| } | ||
|
|
||
| /** Calculate the number of pages */ | ||
| getNumberOfPages(): number { | ||
| return Math.ceil(this.length / this.pageSize) - 1; | ||
| return Math.ceil(this.length / this.pageSize); |
There was a problem hiding this comment.
Is pageSize == 0 a thing we have to worry about here? (I see you checked for it above).
|
Marked as |
andrewseguin
force-pushed
the
paginator-for-real-num-pages
branch
from
2644ca0 to
a8be029
Compare
andrewseguin
force-pushed
the
paginator-for-real-num-pages
branch
from
a8be029 to
1d5b9e6
Compare
andrewseguin
added
P2
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
Based off of angular#10720 (adding the demo page) Changes the paginator's `getNumberOfPages` such that it returns the actual number of pages that are on the paginator rather than the max page index. This better matches the method name and description. E.g. right now if you have one page, the function returns `0` rather than `1`, which is unexpected. Fixes angular#10699
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #10720 (adding the demo page)
Changes the paginator's
getNumberOfPagessuch that it returns the actual number of pages that are on the paginator rather than the max page index. This better matches the method name and description.E.g. right now if you have one page, the function returns
0rather than1, which is unexpected.Fixes #10699