fix(theme): apply base theme classes at location the theme is included #10737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
pr: needs review
target: patch
googlebot
added
the
cla: yes
jelbourn
reviewed
Apr 6, 2018
src/lib/core/_core.scss
Outdated
| @@ -48,7 +49,8 @@ | |||
| } | |||
|
|
|||
| // Marker that is used to determine whether the user has added a theme to their page. | |||
| .mat-theme-loaded-marker { | |||
| .mat-theme-loaded-marker, | |||
| &.mat-theme-loaded-marker { | |||
There was a problem hiding this comment.
This one should actually be @at-root
crisbeto
reviewed
Apr 6, 2018
src/lib/core/_core.scss
Outdated
| @@ -48,7 +49,8 @@ | |||
| } | |||
|
|
|||
| // Marker that is used to determine whether the user has added a theme to their page. | |||
| .mat-theme-loaded-marker { | |||
| .mat-theme-loaded-marker, | |||
| &.mat-theme-loaded-marker { | |||
There was a problem hiding this comment.
I'm not sure whether it makes sense to change the selector on this one. The class gets applied to an element that we create dynamically which gets removed immediately afterwards.
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.