Skip to content

chore(calendar): remove explicit preserveWhitespaces setting #10761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2018
Merged

chore(calendar): remove explicit preserveWhitespaces setting #10761

merged 1 commit into from
Apr 11, 2018

Conversation

rafaelss95
Copy link
Contributor

@rafaelss95 rafaelss95 commented Apr 8, 2018

The explicit preserveWhitespaces setting were removed in #10216, but #9639 added it to a new component (MatCalendarHeader). To prevent future mistakes like that I've added "!preserveWhitespaces": ".*" to the validate-decorators rule in tslint.json.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 8, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 9, 2018
@josephperrott josephperrott added target: patch This PR is targeted for the next patch release and removed pr: merge safe labels Apr 9, 2018
@josephperrott
Copy link
Member

Removing merge safe as this could potentially have downstream effects. But it should be fine.

@tinayuangao tinayuangao merged commit 34fe17e into angular:master Apr 11, 2018
@rafaelss95 rafaelss95 deleted the fix-explicit-preserve-whitespaces branch April 12, 2018 00:42
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants