Skip to content

refactor: remove duplicate types and correct some TODOs #10763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2018
Merged

refactor: remove duplicate types and correct some TODOs #10763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cdk/table/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export class CdkTable<T> implements CollectionViewer, OnInit, AfterContentChecke
this._switchDataSource(dataSource);
}
}
private _dataSource: DataSource<T> | Observable<T[]> | T[] | T[];
private _dataSource: DataSource<T> | Observable<T[]> | T[];

// TODO(andrewseguin): Remove max value as the end index
// and instead calculate the view on init and scroll.
Expand Down
2 changes: 1 addition & 1 deletion src/lib/icon/icon-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ export class MatIconRegistry {
return inProgressFetch;
}

// TODO(jelbourn): for some reason, the `finally` operator "loses" the generic type on the
// TODO(jelbourn): for some reason, the `finalize` operator "loses" the generic type on the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I think it's outdated and maybe can be removed. @jelbourn

// Observable. Figure out why and fix it.
const req = this._httpClient.get(url, {responseType: 'text'}).pipe(
finalize(() => this._inProgressUrlFetches.delete(url)),
Expand Down
4 changes: 2 additions & 2 deletions src/lib/menu/menu-trigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ export const MAT_MENU_SCROLL_STRATEGY =
}
});

// TODO(andrewseguin): Remove the kebab versions in favor of camelCased attribute selectors

/** Default top padding of the menu panel. */
export const MENU_PANEL_TOP_PADDING = 8;

// TODO(andrewseguin): Remove the kebab versions in favor of camelCased attribute selectors

/**
* This directive is intended to be used in conjunction with an mat-menu tag. It is
* responsible for toggling the display of the provided menu instance.
Expand Down