refactor(tree): ensure input is applied to the getter and not the setter #10764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
rafaelss95
commented
Apr 9, 2018
| set level(value: number) { | ||
| this._level = coerceNumberProperty(value); | ||
| this._setPadding(); | ||
| } | ||
| get level(): number { return this._level; } | ||
| _level: number; | ||
|
|
||
| /** The indent for each level. Default number 40px from material design menu sub-menu spec. */ | ||
| // TODO(tinayuangao): Make indent working with a string with unit, e.g. 10em |
There was a problem hiding this comment.
@tinayuangao Not related to this PR, but can't this be done using coerceCssPixelValue?
There was a problem hiding this comment.
coerceCssPixelValue got in recently so it probably wasn't there when the tree was implemented.
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to CODING_STANDARDS.md#getters-and-setters: