Skip to content

docs(overlay): mention the FlexibleConnectedPositionStrategy in the overlay guide #10842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2018
Merged

docs(overlay): mention the FlexibleConnectedPositionStrategy in the overlay guide #10842

merged 1 commit into from
Apr 26, 2018

Conversation

crisbeto
Copy link
Member

Adds a description of the FlexibleConnectedPositionStrategy to the overlay module guide.

@crisbeto
docs(overlay): mention the FlexibleConnectedPositionStrategy in the o…
8931e93 
…verlay guide

Adds a description of the `FlexibleConnectedPositionStrategy` to the overlay module guide.
@crisbeto crisbeto added pr: needs review docs This issue is related to documentation labels Apr 13, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner April 13, 2018 19:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 13, 2018
jelbourn
jelbourn approved these changes Apr 25, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Apr 25, 2018
@jelbourn jelbourn added this to the 6.0 milestone Apr 25, 2018
@jelbourn jelbourn added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Apr 25, 2018
@andrewseguin andrewseguin merged commit 5c91e73 into angular:master Apr 26, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin