Skip to content

chore: update dgeni-packages #11248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2018
Merged

Conversation

andrewseguin
Copy link
Contributor

The dgeni packages was relying on an older version of typescript, causing issues with enum equality here:

  const directiveDecorator = declaration.decorators
    .filter(decorator => decorator.expression)
    // TODO(devversion): fix this cast
    .filter(decorator => (decorator.expression.kind as any) === SyntaxKind.CallExpression)
    .find(decorator => (decorator.expression as any).expression.getText() === 'Component' ||
                       (decorator.expression as any).expression.getText() === 'Directive');

Closes #11177

@andrewseguin andrewseguin requested a review from jelbourn May 9, 2018 21:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 9, 2018
@andrewseguin andrewseguin added pr: needs review and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels May 9, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 9, 2018
@andrewseguin andrewseguin added target: master only and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels May 9, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 9, 2018
@andrewseguin andrewseguin added pr: merge safe and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels May 9, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 9, 2018
@andrewseguin andrewseguin changed the title chore: update dgeni chore: update dgeni-packages May 9, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels May 9, 2018
@ngbot
Copy link

ngbot bot commented May 9, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch manager" is failing
    pending status "ci/circleci: build" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn
Copy link
Member

jelbourn commented May 9, 2018

Needs to be target: patch if we want it to apply to the docs on the weekly patch release

@jelbourn jelbourn merged commit 9f282b6 into angular:master May 10, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request May 14, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Missing @Input()/@Output() information on API tab (docs site)
3 participants