Skip to content

refactor(dialog,bottom-sheet,snack-bar): use injector to pass config to container instance #11302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2018

Conversation

crisbeto
Copy link
Member

Uses DI to pass in the config object to the various global overlay containers. Compared to the current approach, using the injector has the advantage of allowing the config to be used in the constructor and not having to null-check it everywhere.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 13, 2018
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels May 14, 2018
@ngbot
Copy link

ngbot bot commented May 14, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing
    failure status "branch manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott josephperrott removed the action: merge The PR is ready for merge by the caretaker label May 14, 2018
@josephperrott
Copy link
Member

Looks like CircleCI is still failling

…to container instance

Uses DI to pass in the config object to the various global overlay containers. Compared to the current approach, using the injector has the advantage of allowing the config to be used in the constructor and not having to null-check it everywhere.
@crisbeto crisbeto force-pushed the global-overlay-config-tokens branch from 4c94a0e to f5f279b Compare May 14, 2018 19:27
@crisbeto
Copy link
Member Author

Seems like the Circle failure was a flake.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 14, 2018
@ngbot
Copy link

ngbot bot commented May 14, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch manager" is failing
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@tinayuangao tinayuangao merged commit 4dbbb43 into angular:master May 15, 2018
tinayuangao pushed a commit that referenced this pull request May 15, 2018
…to container instance (#11302)

Uses DI to pass in the config object to the various global overlay containers. Compared to the current approach, using the injector has the advantage of allowing the config to be used in the constructor and not having to null-check it everywhere.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants