Skip to content

fix(cdk-dialog): afterClosed event emitting twice on close #11407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2018
Merged

fix(cdk-dialog): afterClosed event emitting twice on close #11407

merged 1 commit into from
May 22, 2018

Conversation

crisbeto
Copy link
Member

Fixes the afterClosed event from the CDK dialog emitting twice due to the _animationDone callback being invoked both with void and exit consecutively.

Fixes #11398.

@crisbeto
fix(cdk-dialog): afterClosed event emitting twice on close
fcdf718 
* Fixes the `afterClosed` event from the CDK dialog emitting twice due to the `_animationDone` callback being invoked both with `void` and `exit` consecutively.
* Fixes incorrect spelling of "Bulbasaur".

Fixes angular#11398.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 18, 2018
josephperrott
josephperrott approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 21, 2018
@mmalerba mmalerba merged commit 3fdd2cc into angular:master May 22, 2018
mmalerba pushed a commit that referenced this pull request May 24, 2018
@crisbeto @mmalerba
fix(cdk-dialog): afterClosed event emitting twice on close (#11407)
36ff785 
* Fixes the `afterClosed` event from the CDK dialog emitting twice due to the `_animationDone` callback being invoked both with `void` and `exit` consecutively.
* Fixes incorrect spelling of "Bulbasaur".

Fixes #11398.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cdk DialogRef.afterClosed is called twice
4 participants
@crisbeto @josephperrott @googlebot @mmalerba