fix(schematics): remove temp path #11198 #11424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
rafaelss95
reviewed
May 21, 2018
| has = true; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Can't it be just const hasTempFile = tree.files.indexOf('angular_material_schematics-') !== -1;?
crisbeto
reviewed
May 21, 2018
| const files = tree.files; | ||
|
|
||
| let has = false; | ||
| for (const file of files) { |
There was a problem hiding this comment.
If files is an array, you should be able to reduce the assertion to this:
expect(files.find(file => file.includes('angular_material_schematics-'))).toBeTruthy();| expect(has).toBe(false); | ||
| }); | ||
|
|
||
| }); |
There was a problem hiding this comment.
Missing a newline at the end of the file.
jelbourn
approved these changes
May 22, 2018
jelbourn
added
pr: merge safe
target: patch
|
Updated per feedback |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11198 to update the entire path vs just the files.