-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(button): add stroked buttons to examples #11433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -3,3 +3,7 @@ | |||
align-items: center; | |||
justify-content: space-around; | |||
} | |||
|
|||
button, a { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to make sure this margin-right
is only added to ".example-button-row"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I went with the simpler selectors, because we've got style encapsulation, but these could still leak into other elements if we expand the example. It's changed now.
3551737
to
9907a88
Compare
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
2 similar comments
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
Adds the stroked buttons to the button varieties example and includes some margin so the buttons don't stick together. Fixes angular#11379.
9907a88
to
087ad6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds the stroked buttons to the button varieties example and includes some margin so the buttons don't stick together.
Fixes #11379.