fix(select): panel content blurry in some browsers #11434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
After we switched everything over to the `FlexibleConnectedPositionStrategy`, we started using `transform` to handle overlay offsets, however using a subpixel `transform` value will cause some browsers to blur the content of the element. These changes round the select's transforms so the content isn't blurry.
crisbeto
force-pushed
the
select-blurry-content
branch
from
669127e to
d4724bf
Compare
tinayuangao
reviewed
May 21, 2018
| expect(origin).toBe(expectedOrigin, | ||
| // Because the origin depends on the Y axis offset, we also have to | ||
| // round down and check that the difference is within a pixel. | ||
| expect(Math.abs(expectedOrigin - origin) < 2).toBe(true, |
There was a problem hiding this comment.
Can we use Math.floor or Math.ceil to avoid this absolute check?
There was a problem hiding this comment.
This is fine; using abs is the canonical way of checking the magnitude of a delta when you don't care about which is larger
jelbourn
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
May 24, 2018
After we switched everything over to the `FlexibleConnectedPositionStrategy`, we started using `transform` to handle overlay offsets, however using a subpixel `transform` value will cause some browsers to blur the content of the element. These changes round the select's transforms so the content isn't blurry.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we switched everything over to the
FlexibleConnectedPositionStrategy, we started usingtransformto handle overlay offsets, however using a subpixeltransformvalue will cause some browsers to blur the content of the element. These changes round the select's transforms so the content isn't blurry.For reference: