fix(select): inconsistent openedChange event dispatched between browsers #11461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
May 22, 2018
src/lib/select/select.ts
Outdated
| @@ -470,6 +481,22 @@ export class MatSelect extends _MatSelectMixinBase implements AfterContentInit, | |||
| ngOnInit() { | |||
| this._selectionModel = new SelectionModel<MatOption>(this.multiple, undefined, false); | |||
| this.stateChanges.next(); | |||
|
|
|||
| // We need `distinctUntilChanged` here, because some browsers will | |||
| // fire the animation end event twice for the same animation. | |||
There was a problem hiding this comment.
Is there an issue for this on angular/angular?
There was a problem hiding this comment.
I couldn't find one so I filed angular/angular#24084. I'll add a link to the issue in a comment.
Fixes the `openedChange` event being dispatched once when a select is closed on most browsers, but twice in IE and Edge. Fixes angular#11444.
crisbeto
force-pushed
the
11444/select-inconsistent-close-event
branch
from
c6a6f44 to
416d309
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
openedChangeevent being dispatched once when a select is closed on most browsers, but twice in IE and Edge.Fixes #11444.