fix(selection-list): support selecting all via ctrl + a #11502
Conversation
googlebot
added
the
cla: yes
| @@ -394,6 +394,12 @@ export class MatSelectionList extends _MatSelectionListMixinBase implements Focu | |||
| keyCode === HOME ? manager.setFirstItemActive() : manager.setLastItemActive(); | |||
| event.preventDefault(); | |||
| break; | |||
| case A: | |||
| if (event.ctrlKey) { | |||
| this.options.find(option => !option.selected) ? this.selectAll() : this.deselectAll(); | |||
There was a problem hiding this comment.
Is the extra check necessary? Looks like _setAllOptionsSelected already checks the existing state before considering the item "changed"
There was a problem hiding this comment.
We need to know whether there's at least one unselected option. The intended functionality is "deselect all if all are selected, otherwise select all".
crisbeto
force-pushed
the
selection-list-select-all
branch
from
e1aa42d to
9ca09cc
Compare
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
If you can, could you push some new hash so that CircleCI tries to re-run? Would like it to be green before we merge |
Based on the a11y guidelines, listboxes can be able to select/deselect all using ctrl + a. These changes implement the keyboard shortcut on the selection list.
crisbeto
force-pushed
the
selection-list-select-all
branch
from
9ca09cc to
78c6923
Compare
|
Done @andrewseguin. |
Based on the a11y guidelines, listboxes can be able to select/deselect all using ctrl + a. These changes implement the keyboard shortcut on the selection list.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Based on the a11y guidelines, listboxes can be able to select/deselect all using ctrl + a. These changes implement the keyboard shortcut on the selection list.