fix(icon): IE/Edge ignoring style tags inside inline SVG #11531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
May 29, 2018
| const styleTags = svg.querySelectorAll('style') as NodeListOf<HTMLStyleElement>; | ||
|
|
||
| for (let i = 0; i < styleTags.length; i++) { | ||
| styleTags[i].textContent += ' '; |
There was a problem hiding this comment.
Why not just remove the elements?
There was a problem hiding this comment.
This doesn’t override the content, it just adds an empty string to the end so it gets recomputed.
| for (let i = 0; i < styleTags.length; i++) { | ||
| styleTags[i].textContent += ' '; | ||
| } | ||
|
|
There was a problem hiding this comment.
Sure, although it’ll probably look a little weird.
Adds a workaround for an issue in IE11 and Edge where `style` tags inside dynamically-created SVGs will be ignored. Fixes angular#11458.
crisbeto
force-pushed
the
11458/ie-icon-svg-style
branch
from
589d7a5 to
85fa021
Compare
|
Addressed the feedback @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jun 8, 2018
Adds a workaround for an issue in IE11 and Edge where `style` tags inside dynamically-created SVGs will be ignored. Fixes #11458.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a workaround for an issue in IE11 and Edge where
styletags inside dynamically-created SVGs will be ignored.Fixes #11458.