Skip to content

fix(button-toggle): underlying input not disabled when group is disabled #11610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2018
Merged

fix(button-toggle): underlying input not disabled when group is disabled #11610

merged 1 commit into from
Sep 11, 2018
+26 −20

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 1, 2018

Fixes the underlying input element inside a mat-button-toggle not being disabled when the parent toggle group is disabled via a data binding.

Fixes #11608.

@crisbeto crisbeto requested a review from tinayuangao as a code owner June 1, 2018 08:03
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 1, 2018
@crisbeto crisbeto assigned jelbourn and unassigned tinayuangao Jul 28, 2018
jelbourn
jelbourn approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 30, 2018
@ngbot
Copy link

ngbot bot commented Jul 30, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@ngbot
Copy link

ngbot bot commented Aug 27, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

3 similar comments
@ngbot
Copy link

ngbot bot commented Aug 27, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@ngbot
Copy link

ngbot bot commented Aug 27, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@ngbot
Copy link

ngbot bot commented Aug 27, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the 11608/button-toggle-input branch 2 times, most recently from 057cac8 to 20faab6 Compare August 28, 2018 05:16
@crisbeto
fix(button-toggle): underlying input not disabled when group is disabled
efe4fd1 
Fixes the underlying `input` element inside a `mat-button-toggle` not being disabled when the parent toggle group is disabled via a data binding.

Fixes angular#11608.
@crisbeto crisbeto force-pushed the 11608/button-toggle-input branch from 20faab6 to efe4fd1 Compare September 2, 2018 11:04
@jelbourn jelbourn merged commit bd21f21 into angular:master Sep 11, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disabled attribute is partially working on mat-button-toggle-group
4 participants
@crisbeto @jelbourn @googlebot @tinayuangao