Skip to content

fix(select): multi-select checkbox not having an outline in high contrast mode #11667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 5, 2018

Reworks the pseudo checkbox not to remove its border when it becomes checked. This has the advantage of not removing the checkbox outline in high contrast mode.

…rast mode

Reworks the pseudo checkbox not to remove its border when it becomes checked. This has the advantage of not removing the checkbox outline in high contrast mode.
@crisbeto crisbeto requested a review from jelbourn as a code owner June 5, 2018 10:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 5, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 5, 2018
@andrewseguin andrewseguin merged commit 082efa3 into angular:master Jun 7, 2018
andrewseguin pushed a commit that referenced this pull request Jun 8, 2018
…rast mode (#11667)

Reworks the pseudo checkbox not to remove its border when it becomes checked. This has the advantage of not removing the checkbox outline in high contrast mode.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants