Skip to content

fix(autocomplete): model not being updated when typing in input with disabled autocomplete #11695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2018
Merged

fix(autocomplete): model not being updated when typing in input with disabled autocomplete #11695

merged 1 commit into from
Jun 12, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 6, 2018

Fixes the model of an input with matAutocompleteDisabled=true not being updated while typing.

Fixes #11678.

@crisbeto
fix(autocomplete): model not being updated when typing in input with …
a89d676 
…disabled autocomplete

Fixes the model of an input with `matAutocompleteDisabled=true` not being updated while typing.

Fixes angular#11678.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 6, 2018
jelbourn
jelbourn approved these changes Jun 6, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 6, 2018
@jelbourn jelbourn merged commit 429d3bc into angular:master Jun 12, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@crisbeto @victoriaaa234
fix(autocomplete): model not being updated when typing in input with …
3f8711f 
…disabled autocomplete (#11695)

Fixes the model of an input with `matAutocompleteDisabled=true` not being updated while typing.

Fixes #11678.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[matAutocompleteDisabled] disables the connected inputs model binding
3 participants
@crisbeto @jelbourn @googlebot