Skip to content

fix(stepper): reading out wrong amount of steps with NVDA on Firefox #11711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2018
Merged

fix(stepper): reading out wrong amount of steps with NVDA on Firefox #11711

merged 1 commit into from
Jun 12, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 7, 2018

Fixes NVDA on Firefox reading out "Tab 1 of 1" for vertical steppers. Seems to be a similar issue to #11694.

@crisbeto
fix(stepper): reading out wrong amount of options with NVDA on Firefox
fbce067 
Fixes NVDA on Firefox reading out "Tab 1 of 1" for vertical steppers. Seems to be a similar issue to  angular#11694.
@crisbeto crisbeto added the Accessibility This issue is related to accessibility (a11y) label Jun 7, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner June 7, 2018 20:49
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 7, 2018
@crisbeto crisbeto changed the title fix(stepper): reading out wrong amount of options with NVDA on Firefox fix(stepper): reading out wrong amount of steps with NVDA on Firefox Jun 7, 2018
jelbourn
jelbourn approved these changes Jun 7, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 7, 2018
@ngbot
Copy link

ngbot bot commented Jun 7, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit 56e703f into angular:master Jun 12, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@crisbeto @victoriaaa234
fix(stepper): reading out wrong amount of options with NVDA on Firefox (
b03b69c 
#11711)

Fixes NVDA on Firefox reading out "Tab 1 of 1" for vertical steppers. Seems to be a similar issue to  #11694.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot