Skip to content

chore: fix table sticky column file name #11717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

andrewseguin
Copy link
Contributor

The folder and filenames were different (sticky-column vs sticky-columns) which will be an issue for the docs site

@andrewseguin andrewseguin added the target: minor This PR is targeted for the next minor release label Jun 8, 2018
@andrewseguin andrewseguin requested a review from jelbourn June 8, 2018 17:39
@andrewseguin andrewseguin requested a review from amcdnl as a code owner June 8, 2018 17:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 8, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 8, 2018
@ngbot
Copy link

ngbot bot commented Jun 8, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@andrewseguin andrewseguin force-pushed the table-sticky-column-docs branch from 2c12d67 to dc1d4f5 Compare June 8, 2018 19:51
@andrewseguin andrewseguin merged commit 08ad2c9 into angular:master Jun 8, 2018
@Abhishek-Shrotriya
Copy link

Hi, is there any specific date when the sticky/ pinned columns (including horizontal and vertical scrolling) be publicly available, as there is critical need to freeze few columns in my project using Angular material table. Thanks for your help

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants