fix(tree): fix dynamic tree example and demo not closing children (#11148) #11728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: no
victoriaaa234
added
cla: yes
googlebot
added
cla: no
victoriaaa234
added
cla: yes
tinayuangao
reviewed
Jun 11, 2018
| setTimeout(() => { | ||
| if (expand) { | ||
| const nodes = children.map(name => | ||
| new DynamicFlatNode(name, node.level + 1, this.database.isExpandable(name))); | ||
| this.data.splice(index + 1, 0, ...nodes); | ||
| } else { | ||
| this.data.splice(index + 1, children.length); | ||
| for (let i = index + 1; i < this.data.length; i++) { |
There was a problem hiding this comment.
Is this better?
let count = 0;
for (let i = index + 1; i < this.data.length && this.data[i].level > node.level; i++, count++) {}?
this.data.splice(index + 1, count);There was a problem hiding this comment.
Yes, thanks! This definitely saves space
tinayuangao
changed the title
googlebot
added
cla: no
victoriaaa234
added
cla: yes
googlebot
added
cla: no
|
CLAs look good, thanks! |
googlebot
added
cla: yes
This was referenced Jun 27, 2018
victoriaaa234
added a commit
that referenced
this pull request
Jul 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.