Skip to content

Update MatFormField outline DOM structure #11771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2018
Merged

Update MatFormField outline DOM structure #11771

merged 3 commits into from
Jun 26, 2018

Conversation

glouischandra
Copy link
Contributor

Modified Material FormField template so outline DOM is contained with mat-form-field-flex. This approach is more easily overridden by partner team that customizes the look and feel of Material components.

@glouischandra glouischandra requested a review from mmalerba as a code owner June 13, 2018 03:55
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jun 13, 2018
@glouischandra
Modified Material FormField template so outline DOM is contained with…
4e9b321 
…in mat-form-field-flex. This approach is more easily overriden by partner team that customizes the look and feel of Material components.
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jun 13, 2018
@jelbourn jelbourn requested a review from crisbeto June 14, 2018 16:44
@jelbourn
Copy link
Member

@crisbeto could you take a look? I think you're more familiar w/ form-field than me (and Miles is out).

crisbeto
crisbeto approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib/form-field/form-field.html Outdated
@@ -1,6 +1,21 @@
<div class="mat-form-field-wrapper">
<div class="mat-form-field-flex" #connectionContainer
(click)="_control.onContainerClick && _control.onContainerClick($event)">

<!-- Outline used for outline appearance. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there's an extra space between "for" and "outline".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed extra space in new commit. Thanks @crisbeto!

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 14, 2018
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jun 14, 2018
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jun 14, 2018
@josephperrott josephperrott merged commit 1e6acfb into angular:master Jun 26, 2018
josephperrott pushed a commit that referenced this pull request Jun 26, 2018
@glouischandra @josephperrott
Update MatFormField outline DOM structure (#11771)
194b3c7
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@glouischandra @victoriaaa234
Update MatFormField outline DOM structure (#11771)
57ce108
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glouischandra @googlebot @jelbourn @crisbeto @josephperrott