fix(tabs): unable to set aria-label or aria-labelledby on tab #11898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the tab doc we recommend to set `aria-label` or `aria-labelledby` on tabs that don't have text, however doing so doesn't work since we don't proxy the attributes down to the underlying tab. These changes add inputs for `aria-label` and `aria-labelledby`, and proxy the attributes down correctly. Fixes angular#11893.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
josephperrott
pushed a commit
that referenced
this pull request
Jun 26, 2018
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 29, 2018
Along the same lines as angular#11898. In our stepper docs we recommend for people to add a meaningful label via `aria-label` or `aria-labelledby`, however even if they do, the attributes don't get forwarded to the underlying element that has the proper role. These changes add inputs for `aria-label` and `aria-labelledby` and correctly forward the attributes.
jelbourn
pushed a commit
that referenced
this pull request
Jul 10, 2018
Along the same lines as #11898. In our stepper docs we recommend for people to add a meaningful label via `aria-label` or `aria-labelledby`, however even if they do, the attributes don't get forwarded to the underlying element that has the proper role. These changes add inputs for `aria-label` and `aria-labelledby` and correctly forward the attributes.
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
Along the same lines as #11898. In our stepper docs we recommend for people to add a meaningful label via `aria-label` or `aria-labelledby`, however even if they do, the attributes don't get forwarded to the underlying element that has the proper role. These changes add inputs for `aria-label` and `aria-labelledby` and correctly forward the attributes.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the tab doc we recommend to set
aria-labeloraria-labelledbyon tabs that don't have text, however doing so doesn't work since we don't proxy the attributes down to the underlying tab. These changes add inputs foraria-labelandaria-labelledby, and proxy the attributes down correctly.Fixes #11893.