Skip to content

fix(button): don't show hover overlay on devices that don't support hovering #12030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2018
Merged

fix(button): don't show hover overlay on devices that don't support hovering #12030

merged 1 commit into from
Jul 11, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 3, 2018

Fixes the hover overlay persisting on touch devices after tapping on a button.

Fixes #12022.

@crisbeto
fix(button): don't show hover overlay on devices that don't support h…
f3b9420 
…overing

Fixes the hover overlay persisting on touch devices after tapping on a button.

Fixes angular#12022.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 3, 2018
@crisbeto crisbeto requested a review from tinayuangao as a code owner July 3, 2018 05:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 3, 2018
josephperrott
josephperrott approved these changes Jul 3, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 3, 2018
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jul 5, 2018
@crisbeto
fix(expansion-panel): disable hover highlight on non-hover devices
3e15c31 
Disables the expansion panel header's hover if the device doesn't support hovering. This prevents the header from appearing as stuck if the user taps it on a touch device.

Relates to angular#12030.
@crisbeto crisbeto mentioned this pull request Jul 5, 2018
Merged
jelbourn
jelbourn approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jelbourn pushed a commit that referenced this pull request Jul 11, 2018
@crisbeto @jelbourn
fix(expansion-panel): disable hover highlight on non-hover devices
7744474 
Disables the expansion panel header's hover if the device doesn't support hovering. This prevents the header from appearing as stuck if the user taps it on a touch device.

Relates to #12030.
jelbourn pushed a commit that referenced this pull request Jul 11, 2018
@crisbeto @jelbourn
fix(expansion-panel): disable hover highlight on non-hover devices (#…
25eb43f 
…12080)

Disables the expansion panel header's hover if the device doesn't support hovering. This prevents the header from appearing as stuck if the user taps it on a touch device.

Relates to #12030.
@jelbourn jelbourn merged commit 947c29a into angular:master Jul 11, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@crisbeto @victoriaaa234
fix(expansion-panel): disable hover highlight on non-hover devices (#…
c2700b6 
…12080)

Disables the expansion panel header's hover if the device doesn't support hovering. This prevents the header from appearing as stuck if the user taps it on a touch device.

Relates to #12030.
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@crisbeto @victoriaaa234
fix(button): don't show hover overlay on devices that don't support h…
9758af3 
…overing (#12030)

Fixes the hover overlay persisting on touch devices after tapping on a button.

Fixes #12022.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott josephperrott approved these changes

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On touch, buttons get a lingering hover state.
4 participants
@crisbeto @jelbourn @josephperrott @googlebot