Skip to content

fix(button): unable to set a custom tabindex on a link button #12042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 3, 2018

Fixes the consumer's tabIndex being overwritten to always be 0 on button links.

Fixes #12041.

Fixes the consumer's `tabIndex` being overwritten to always be 0 on button links.

Fixes angular#12041.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 3, 2018
@crisbeto crisbeto requested a review from tinayuangao as a code owner July 3, 2018 16:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 3, 2018
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 3, 2018
@jelbourn jelbourn merged commit cb6c621 into angular:master Jul 12, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
Fixes the consumer's `tabIndex` being overwritten to always be 0 on button links.

Fixes #12041.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to set tabindex of material buttons
5 participants