Skip to content

fix(icon): reverse for loop when removing child nodes from mat-icon #12078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2018
Merged

fix(icon): reverse for loop when removing child nodes from mat-icon #12078

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff2fec4
fix(icon): reverse for loop when removing child nodes from mat-icon
pavel-agarkov Jul 5, 2018
cb8a840
changing childCount from const to let to make it mutable
pavel-agarkov Jul 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib/icon/icon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,12 @@ export class MatIcon extends _MatIconMixinBase implements OnChanges, OnInit, Can

private _clearSvgElement() {
const layoutElement: HTMLElement = this._elementRef.nativeElement;
const childCount = layoutElement.childNodes.length;
let childCount = layoutElement.childNodes.length;

// Remove existing non-element child nodes and SVGs, and add the new SVG element. Note that
// we can't use innerHTML, because IE will throw if the element has a data binding.
for (let i = 0; i < childCount; i++) {
const child = layoutElement.childNodes[i];
while (childCount--) {
const child = layoutElement.childNodes[childCount];

// 1 corresponds to Node.ELEMENT_NODE. We remove all non-element nodes in order to get rid
// of any loose text nodes, as well as any SVG elements in order to remove any old icons.
Expand Down