Skip to content

fix(expansion-panel): disable hover highlight on non-hover devices #12080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2018
Merged

fix(expansion-panel): disable hover highlight on non-hover devices #12080

merged 1 commit into from
Jul 11, 2018
+9 −0

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 5, 2018

Disables the expansion panel header's hover if the device doesn't support hovering. This prevents the header from appearing as stuck if the user taps it on a touch device.

Relates to #12030.

@crisbeto
fix(expansion-panel): disable hover highlight on non-hover devices
3e15c31 
Disables the expansion panel header's hover if the device doesn't support hovering. This prevents the header from appearing as stuck if the user taps it on a touch device.

Relates to angular#12030.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 5, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 5, 2018
josephperrott
josephperrott approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 9, 2018
@jelbourn jelbourn merged commit 25eb43f into angular:master Jul 11, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@crisbeto @victoriaaa234
fix(expansion-panel): disable hover highlight on non-hover devices (#…
c2700b6 
…12080)

Disables the expansion panel header's hover if the device doesn't support hovering. This prevents the header from appearing as stuck if the user taps it on a touch device.

Relates to #12030.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @josephperrott @jelbourn @googlebot