Skip to content

fix(selection-list): form control disable locks disabled property #12113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2018
Merged

fix(selection-list): form control disable locks disabled property #12113

merged 1 commit into from
Jul 12, 2018

Conversation

devversion
Copy link
Member

  • Fixes that the setDisabledState control value accessor hook updates the disabled state of each option individually. This causes the MatSelectionList#disabled property to no longer have any effect.

Fixes #12107

@devversion
fix(selection-list): form control disable locks disabled property
4a23e0a 
* Fixes that the `setDisabledState` control value accessor hook updates the disabled state of each option individually. This causes the `MatSelectionList#disabled` property to no longer have any effect.

Fixes angular#12107
@devversion devversion added the target: patch This PR is targeted for the next patch release label Jul 9, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 9, 2018
josephperrott
josephperrott approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 9, 2018
crisbeto
crisbeto approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit fcc8875 into angular:master Jul 12, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@devversion @victoriaaa234
fix(selection-list): form control disable locks disabled property (#1…
c0d684a 
…2113)

Fixes that the `setDisabledState` control value accessor hook updates the disabled state of each option individually. This causes the `MatSelectionList#disabled` property to no longer have any effect.

Fixes #12107
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-selection-list): cannot change disabled status via @Input() disabled after programmatically change it
5 participants
@devversion @crisbeto @josephperrott @jelbourn @googlebot