fix(ripple): don't hide directive host in high contrast #12168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `matRipple` directive can be applied on various HTML elements. In high contrast mode we currently hide the host element. It's wrong to assume that the element with `matRipple` applied can be just made invisible. In order to keep the high contrast mode working, we just hide the actual ripple elements instead of the host element. * Fixes that components using their own `RippleTarget` (chips, tab-nav-bar) are still showing ripples in high contrast mode that obstruct the actual content.
devversion
added
Accessibility
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
that referenced
this pull request
Jul 20, 2018
josephperrott
pushed a commit
that referenced
this pull request
Jul 20, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
matRippledirective can be applied on various HTML elements. In high contrast mode we currently hide the host element. It's wrong to assume that the element withmatRippleapplied can be just made invisible. In order to keep the high contrast mode working, we just hide the ripple elements instead of the host element.Fixes that components using their own
RippleTarget(chips, tab-nav-bar) are still showing ripples in high contrast mode that obstruct the actual content.