fix(tabs): changed after checked error when using isActive in view #12206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a "changed after checked" error being thrown if the consumer is using the `isActive` property of a tab somewhere in the view. * Reworks the `MatTab` to only have one `stateChanges` subject rather than one per property. Fixes angular#12197.
googlebot
added
the
cla: yes
josephperrott
approved these changes
Aug 7, 2018
| // Emitting this value after change detection has run | ||
| // since the checked content may contain this variable' | ||
| Promise.resolve().then(() => this.selectedIndexChange.emit(indexToSelect)); | ||
| if (this._selectedIndex != indexToSelect) { |
There was a problem hiding this comment.
That's what was being used here before so I kept it. I'm guessing it was there to handle somebody passing the index in as a string.
jelbourn
added
the
P1
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isActiveproperty of a tab somewhere in the view.MatTabto only have onestateChangessubject rather than one per property.Fixes #12197.