Skip to content

fix(drag-drop): make CDK_DROP_CONTAINER public #12214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2018
Merged

fix(drag-drop): make CDK_DROP_CONTAINER public #12214

merged 3 commits into from
Jul 17, 2018

Conversation

jorroll
Copy link

@jorroll jorroll commented Jul 15, 2018

fixes #12213

@jorroll jorroll requested a review from crisbeto as a code owner July 15, 2018 01:45
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 15, 2018
@crisbeto crisbeto changed the title feat(drag-drop): make CDK_DROP_CONTAINER public fix(drag-drop): make CDK_DROP_CONTAINER public Jul 15, 2018
crisbeto
crisbeto reviewed Jul 15, 2018
View reviewed changes
src/cdk-experimental/drag-drop/public-api.ts Outdated
@@ -7,6 +7,7 @@
*/

export * from './drop';
export {CDK_DROP_CONTAINER} from './drop-container';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you switch this one to export *?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

upd: export * from ./drop-container
a3d5fb1 
responding to review feedback
crisbeto
crisbeto approved these changes Jul 15, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: master only labels Jul 15, 2018
@jorroll
Copy link
Author

jorroll commented Jul 15, 2018 •
edited
Loading

@crisbeto actually, right after responding to your feedback I realized, should the /** @docs-private */ comment be removed from the CdkDropContainer interface now that it's also being exported?

@crisbeto
Copy link
Member

Sure. That tag only says whether the symbol should be displayed in the docs.

@jorroll
Copy link
Author

jorroll commented Jul 15, 2018

👍 done

@josephperrott josephperrott merged commit 9d53f67 into angular:master Jul 17, 2018
josephperrott pushed a commit that referenced this pull request Jul 17, 2018
@josephperrott
fix(drag-drop): make CDK_DROP_CONTAINER public (#12214)
b9cece4
@jorroll jorroll deleted the drag-drop-pub-drop-container branch July 17, 2018 15:22
@jorroll
Copy link
Author

jorroll commented Jul 17, 2018

🎉

josephperrott pushed a commit that referenced this pull request Jul 17, 2018
@josephperrott
fix(drag-drop): make CDK_DROP_CONTAINER public (#12214)
40c3a47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(drag-drop): make CDK_DROP_CONTAINER token public api
4 participants
@jorroll @crisbeto @googlebot @josephperrott