Skip to content

build: add git-semver-tags to dev dependencies #12230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

  • Adds the git-semver-tags module to the dev dependencies. We are using this module in our changelog task and therefore it should be part of our dev dependencies. This is also necessary because otherwise running gulp does not work for non-flattened node_modules (e.g. pnpm)

* Adds the `git-semver-tags` module to the dev dependencies. We are using this module in our `changelog` task and therefore it should be part of our dev dependencies. This is also necessary because otherwise running gulp does not work for non-flattened `node_modules` (e.g. pnpm)
@devversion devversion requested a review from jelbourn as a code owner July 16, 2018 13:12
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 16, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 16, 2018
@josephperrott josephperrott merged commit 1c67663 into angular:master Jul 18, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants