Skip to content

docs(datepicker): custom datepicker header demo styling not working #12253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

crisbeto
Copy link
Member

Fixes some styles in the datepicker header example not working due to style encapsulation. Also takes the chance to make the text less bold.

For reference:
angular_material_-_google_chrome_2018-07-17_22-22-43

Fixes some styles in the datepicker header example not working due to style encapsulation. Also takes the chance to make the text less bold.
@crisbeto crisbeto requested review from amcdnl and jelbourn as code owners July 17, 2018 20:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 17, 2018
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change anything about the encapsulation? It seems like we just moved it from a separate file to string literals.

@crisbeto
Copy link
Member Author

It does. Previously the styles were encapsulated to the demo component, but now they're moved to the custom header. I moved them into the literal, because we have the template in a literal as well, which makes the example a little more concise.

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 18, 2018
@josephperrott josephperrott merged commit 7aa64df into angular:master Jul 18, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants